Add Autoloaded_Options_Check for missing $autoload parameter - #1413

What?

Closes #28

Adds a new check, autoloaded_options, that warns plugin authors when add_option() or update_option() is called without explicitly setting the $autoload parameter.

Why?

When the $autoload parameter is omitted, WordPress determines the value based on the WordPress version and whether the option already exists. This implicit decision can lead to options being loaded on every page request, which can bloat the alloptions row and slow down requests. Letting the author choose explicitly makes the performance trade-off intentional.

How?

Custom PHPCS sniff PluginCheck.CodeAnalysis.AutoLoadedOptions that wraps AbstractFunctionParameterSniff. The sniff targets the two call sites (the $autoload parameter sits at position 4 on add_option after a deprecated arg, and at position 3 on update_option). Calls without an explicit $autoload produce a single warning per call site; an explicit boolean true or false is left untouched, including the WP 6.6+ recommendation to pass boolean autoload instead of 'yes'/'no' strings.

A new check class Autoloaded_Options_Check registers the sniff under the performance category. It is wired into Default_Check_Repository under the autoloaded_options slug.

Files touched:

• phpcs-sniffs/PluginCheck/Sniffs/CodeAnalysis/AutoLoadedOptionsSniff.php (new sniff)
• phpcs-sniffs/PluginCheck/Tests/CodeAnalysis/AutoLoadedOptionsUnitTest.{inc,php} (sniff unit test)
• phpcs-sniffs/PluginCheck/ruleset.xml (registers the new rule)
• includes/Checker/Checks/Performance/Autoloaded_Options_Check.php (check class)
• includes/Checker/Default_Check_Repository.php (registration)
• docs/checks.md (new row)
• tests/phpunit/testdata/plugins/test-plugin-autoloaded-options-check-{with,without}-errors/load.php (PHPUnit fixtures)
• tests/phpunit/tests/Checker/Checks/Autoloaded_Options_Check_Tests.php (PHPUnit integration test)

Testing Instructions

1. Apply the patch and activate plugin-check in a WordPress install.
2. Run wp plugin-check list-checks and confirm autoloaded_options is listed in the performance category.
3. Create a test plugin containing both forms below and run wp plugin-check check <plugin> on it.
   • Triggers a warning:

     add_option( 'opt_a' );
     add_option( 'opt_b', 'value' );
     update_option( 'opt_c' );
     update_option( 'opt_d', 'value' );

   • Clean (no warning):

     add_option( 'opt_a', 'value', '', false );
     add_option( 'opt_b', 'value', '', true );
     update_option( 'opt_c', 'value', false );
     update_option( 'opt_d', 'value', true );

4. Verify four warnings appear on the first plugin (codes PluginCheck.CodeAnalysis.AutoLoadedOptions.add_option_autoloadMissing and PluginCheck.CodeAnalysis.AutoLoadedOptions.update_option_autoloadMissing) and zero autoloaded_options results on the second.

Automated tests:

• composer test runs the PHPUnit integration tests against both fixtures.
• Sniff unit test runs via cd phpcs-sniffs && php vendor/bin/phpunit vendor/squizlabs/php_codesniffer/tests/AllTests.php --filter AutoLoadedOptions --no-coverage.

AI Usage Disclosure

• This PR was created without the help of AI tools
• This PR includes AI-assisted code or content

If AI tools were used, please describe how they were used:
Used Claude Code for code generation, refactoring and documentation drafting under direction of maintainer.